Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linksafe should add the column to the output #11

Open
koppor opened this issue Oct 27, 2022 · 4 comments
Open

linksafe should add the column to the output #11

koppor opened this issue Oct 27, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@koppor
Copy link

koppor commented Oct 27, 2022

Limit to 10 failed links

Similar to reviewdog action or https://github.com/errata-ai/vale-action

grafik

@TechWiz-3
Copy link
Owner

So the workflow will make a PR removing broken links?

@TechWiz-3 TechWiz-3 added the enhancement New feature or request label Oct 29, 2022
@koppor
Copy link
Author

koppor commented Nov 2, 2022

The use-case is that there might be external. They do not have write-request to the repository. They use the feature of GitHub's pull request to contribute. For GitHub pull requests, some "fancy" interaction possibilities exist. I like the one for commenting on the concrete lines.

@koppor
Copy link
Author

koppor commented Nov 2, 2022

Maintainers of a repository still can decide whether they want to use the PR method or just commit to the main branch. I think, it really depends on the repository. For instance, at JabRef, we have >400 external contributors, whereas in my own "toy projects", I am the single one contributor and work differently.

@koppor
Copy link
Author

koppor commented Oct 12, 2024

TL;DR: linksafe should add the column to the output


I think, what would help there is to use errorformat for output. ({file}:{line number}:{column number}: {message})

Current output is:

==== Failed links ====
In ./README.md on line 113, link: https://github.com/search?utf8=%E2%9C%93&q=label%3Ahacktoberfest+state%3Aopen+type%3Aissue+language%3ADart&type=Issues&ref=advsearch&l=React&l=
In ./README.md on line 125, link: https://github.com/search?utf8=%E2%9C%93&q=label%3Ahacktoberfest+state%3Aopen+type%3Aissue+language%3ATypescript&type=Issues&ref=advsearch&l=Typescript

Having errorformat in place, one could use other tools for commenting on PRs (such as reviewdog).


One could also configure reviewdog to follow the format of linksave

reviewdog -efm="In %f on line %l, %m" -diff="git diff FETCH_HEAD"

I need to test whether the column is a required input.

Independent of that, linksafe should add the column to the output


For direct posting: Google results:

@koppor koppor changed the title Add failure as comments on PR linksafe should add the column to the output Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants