Auth project Vittoria #340
Conversation
There was a problem hiding this comment.
Hi Vittoria, good job with setting up your final project implementing the auth part! Works well, but an important part is missing which is field validation. The username should have a minimum length, the e-mail field is not checking the value inserted is an actual e-mail address and the password also is recommended to have some rules set. If the valued entered (or missing) are not allowing the user to register, there should be error messages displayed in the UI for a good user experience, and to understand the instructions on how to register. So please add this fundamental part to your app. Another tip: our BE service is quite slow using a free account on Render, a way to mitigate this issue is by adding a loading state. Another small thing, set the max height of the page to fit the content, there is quite some vertical scrolling even if the page is empty, I left a comment in the code :)
| align-items: center; | ||
| justify-content: center; | ||
| padding: 20px; | ||
| height: 100vh; |
There was a problem hiding this comment.
remove this height property from here, and add height: 100vh to body. Do the same with the background-color, apply it to the body and not to this inner div. This way you will remove the vertical excessive scrolling 👍
Netlify link
https://doggyadopt.netlify.app/
Collaborators
[vittoriamatteoli]