Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project-Auth Lovisa, Axel, Alexandra #343

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

Xikitita
Copy link

Netlify link

https://clever-scone-066fd8.netlify.app/

Collaborators

[Lovisaaberg, AHPIXI]

Copy link
Contributor

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello team! You did a great job with your auth API and starting off your final project app. The app works well and it meets the requirements. The animations make it fun and you added some error messages to display for the user experience. This is very important, however try to be more specific with the reasons why it "couldn't create user", like if the email already exists. I recommend to validate the input values like name (now it accepts a number value), and add some rules to password or username (at the moment you can input psw and username of just 1 character). iI could be done either in the BE, for example:

password: { 
    type: String, 
    required: true,
    validate: {
        validator: function(v) {
            return v.length >= 8;
        },
        message: props => `Password should be at least 8 characters long!`
    }
}

or in the FE, now you know how to ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants