-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Business site #363
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with your business site Helene! ⭐
It looks like the structure has two versions of the index.html and style.css files (one directly in the root and one inside the code folder). Please remove any unused code, folders, files to make your code cleaner.
Hero Section with Video:
The use of a video as a background in the hero section is a fantastic touch! You've correctly set the video to autoplay, mute, and loop, which makes for a dynamic and engaging landing experience. The fallback message for browsers that don’t support HTML5 video is a nice accessibility consideration. 👍
Navigation Menu:
Your navigation menu is simple and effective. It’s good to see you using an unordered list for the links, which is a semantic way to organize navigation items. Consider wrapping each <a>
tag within a <li>
to follow best practices in HTML structure, as this improves both accessibility and maintainability.
Another alternative would be to change it to a nav
. Then you could remove any list elements.
Hero Text Overlay:
The text overlay in the hero section is well-placed. Make sure that the text is readable against the video background.
Form
Your form is very cute and fits well with the rest of your site! Just a little tip: when the label is wrapping the input, you don't need to add the for
/id
attributes.
Clean Code
- Consider using more indentation to increase readability:
<label class="checkbox">
<input
required
type="checkbox"
id="terms"
name="terms"
/>
I agree to the terms and conditions</a>
</label>
- It's a bit out of date to use the br tag, so consider using spans and/or flexbox to layout your elements
- Change your VSC indentation settings to be 2 spaces
Overall, you're doing an excellent job. With a few more tweaks, your site will not only look great but your code will also be more readable! Keep up the fantastic work! 🎉
<div class="hero-video"> | ||
<video autoplay muted loop> | ||
<source src="3633003-hd_1906_1080_30fps.mp4" type="video/mp4"> | ||
Din webbläsare stödjer inte HTML5 video. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code is in general clear and well structured, but could be good to be consistent in english
|
||
/*navigation menu */ | ||
|
||
.navbar { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean and stylish navbar! Want to use something similar in my next :)
<input type="email" id="email" name="email" placeholder="E-mail" required><br><br> | ||
</label> | ||
|
||
<!-- date of birth --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smart with date of birth! could be good also to have a required on date of birth as well
|
||
|
||
|
||
/* Responsive design */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks great and responsive except for the box containing Sign up. Could look great if it stays as a smaller rectangle on wider screen. It looks great on a phone though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a beautiful page with an amazing hero video and color scheme. It works perfectly both the form and adapting to different sizes.
It is clean and elegant. The code is clean and well structured. The style.css could use some more comments.
Great work Helene!
Link to deployed project: https://lustrous-crisp-6b8347.netlify.app/