Week 9 Design hand-off Emma E #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheroptera
reviewed
Apr 14, 2023
There was a problem hiding this comment.
Your project looks well-structured and your page seem to show all the elements required (without seeing the design spec). Now it's the fun part left - The CSS! Wiiihooo! 🥳
I noticed that all your CSS-files are in the components folder. A suggestion would be to create a CSS-folder for them, to make it easier to find what you're looking for when browsing through the files.
You've done a really good job so far! 👏 Can't wait to see what it will look like styled 😄
| return ( | ||
| <div className="join"> | ||
| <p>Join our full-body workout inspired by Ballet, Pilates, and Yoga.</p> | ||
| <button className="joinBtn" type="button">Join Us!</button> |
There was a problem hiding this comment.
Since the buttons are styled the same way, how about making a reusable button component? 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.