Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoComplete] 未完全匹配时，框内按回车键，弹框未收起，且控制台报错 #2298

Closed
ghostpanda opened this issue Jun 19, 2023 · 5 comments
Closed

[AutoComplete] 未完全匹配时，框内按回车键，弹框未收起，且控制台报错 #2298

ghostpanda opened this issue Jun 19, 2023 · 5 comments
Labels
🐞 bug Something isn't working to be published fixed, not be published

Comments

@ghostpanda
Copy link

tdesign-react 版本

1.1.10

重现链接

No response

重现步骤

未完全匹配框内按回车键，弹框未收起，后台报错
image

image

期望结果

弹框收起，控制台无报错

实际结果

No response

框架版本

React(18.2.0)

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

No response
@github-actions
Copy link
Contributor

👋 @ghostpanda，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@chaishi chaishi added the 🐞 bug Something isn't working label Jun 19, 2023
@chaishi
Copy link
Collaborator

chaishi commented Jun 19, 2023

信息已收到，抽空处理

@Ali-ovo
Copy link
Contributor

Ali-ovo commented Jun 19, 2023

未完全匹配框内按回车键，弹框未收起，后台报错

我感觉这个交互可以改成
当没有匹配的时候 按回车 会自动填入第一项会不会交互更友好一点

如果这个交互可以的话，我可以来帮忙修复这个 issues

@ghostpanda
Copy link
Author

未完全匹配框内按回车键，弹框未收起，后台报错

我感觉这个交互可以改成 当没有匹配的时候 按回车 会自动填入第一项会不会交互更友好一点

如果这个交互可以的话，我可以来帮忙修复这个 issues

AutoComplete本质上是Input的一个扩展，毕竟不是Select，从这个角度看，应该不需要默认选中第一项😀

Ali-ovo pushed a commit to Ali-ovo/tdesign-react that referenced this issue Jun 19, 2023
fix(auto-complete): fix: error when pressing enter
8f1d964 
fix Tencent#2298
@Ali-ovo Ali-ovo mentioned this issue Jun 19, 2023
Merged
16 tasks
@Ali-ovo
Copy link
Contributor

Ali-ovo commented Jun 19, 2023

未完全匹配框内按回车键，弹框未收起，后台报错

我感觉这个交互可以改成 当没有匹配的时候 按回车 会自动填入第一项会不会交互更友好一点
如果这个交互可以的话，我可以来帮忙修复这个 issues

AutoComplete本质上是Input的一个扩展，毕竟不是Select，从这个角度看，应该不需要默认选中第一项😀

但是单单回车关闭下拉框的交互也是有点过于生硬

Ali-ovo pushed a commit to Ali-ovo/tdesign-react that referenced this issue Jun 21, 2023
@Ali-ovo
fix(auto-complete): fix: error when pressing enter
d249bba 
fix Tencent#2298
Ali-ovo added a commit to Ali-ovo/tdesign-react that referenced this issue Dec 29, 2023
@Ali-ovo
fix: fix bug
6f07724 
fix Tencent#2298
@HaixingOoO HaixingOoO added the to be published fixed, not be published label Dec 29, 2023
NWYLZW added a commit that referenced this issue Jan 11, 2024
@Ali-ovo @NWYLZW
fix(auto-complete): fix: error when pressing enter (#2300)
2aefffb 
* fix: fix bug

fix #2298

* remove useless comment

* return and no emit event

---------

Co-authored-by: YiJie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working to be published fixed, not be published
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ghostpanda @chaishi @HaixingOoO @Ali-ovo