This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Notifications (Preview) #2
Draft
shadow578
wants to merge
20
commits into
kohai
Choose a base branch
from
feature/notifications
base: kohai
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is now somewhat nicer :D
(db model still broken tho)
this concept wouldn't have worked, as notifications cannot be easily stored as, for example, json...
still nowhere near production ready
(WIP; MediaUpdateNotificationsWorker contains testing code)
avoid sending the same notification multiple times
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds notifications about airing anime to Tenshi.
The Notification processing is handled using WorkManager.
Notifications are currently not stable and need way more testing to be considered mature.
Merge as a preview feature to make (longer term) testing easier
TODO
localize notification contentChecks
All UI Strings are localized