Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vivado version not detected correctly when verifying the setup #701

Open
fuzesa opened this issue Nov 11, 2024 · 1 comment
Open

Vivado version not detected correctly when verifying the setup #701

fuzesa opened this issue Nov 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@fuzesa
Copy link

fuzesa commented Nov 11, 2024

Describe the bug
When the user clicks the Verify Setup button within the Configuration section, it attempts to get the version of the installed Vivado application that was provided in the settings. The problem is that in

let result = await checkBinary(selectedTool, installationPath, selectedTool.toLocaleLowerCase(), ['--version']);
file, the --version flag is hardcoded, but the two dashes don't work, because the Vivado executable requires only a single dash in order to print the correct version (please see screenshot below). This leads to Verify Setup failing. (See second screenshot)

To Reproduce
Set the correct path to the Vivado executable and afterwards click on the Verify Setup button.

Please complete the following information:

  • OS: Arch Linux
  • VSCode version 1.95.2

Screenshots
image
image

@fuzesa fuzesa added the bug Something isn't working label Nov 11, 2024
@fuzesa
Copy link
Author

fuzesa commented Nov 11, 2024

Perhaps some modifications similar to this could be added:

fuzesa@80044f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant