Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a CODEOWNERS file to auto assign reviewers #8

Open
DhruvaG2000 opened this issue Oct 17, 2024 · 6 comments · Fixed by #31 · May be fixed by #32
Open

Create a CODEOWNERS file to auto assign reviewers #8

DhruvaG2000 opened this issue Oct 17, 2024 · 6 comments · Fixed by #31 · May be fixed by #32
Assignees
Labels
enhancement New feature or request

Comments

@DhruvaG2000
Copy link
Collaborator

We need to add a CODEOWNERS file [1] to this repo so that we can auto assign reviewers.

[1] https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

@DhruvaG2000 DhruvaG2000 added the enhancement New feature or request label Nov 2, 2024
@DhruvaG2000
Copy link
Collaborator Author

We should take inspiration from how it's being done in Zephyr: https://github.com/zephyrproject-rtos/zephyr/blob/main/CODEOWNERS

If you see their file too has "Errors" according to github, but they don't use the "Github" way of assiging reviewers it seems like they do some amount of scripting here: https://github.com/zephyrproject-rtos/zephyr/blob/main/.github/workflows/assigner.yml which ultimately runs a python script:
https://github.com/zephyrproject-rtos/zephyr/blob/main/scripts/set_assignees.py

This script then parses https://github.com/zephyrproject-rtos/zephyr/blob/main/MAINTAINERS.yml and then auto assigns reviewers.

@StaticRocket StaticRocket linked a pull request Nov 2, 2024 that will close this issue
@StaticRocket
Copy link
Member

Found a workflow that does the same thing the zephyr project tool was doing, but without reusing the CODEOWNERS format, so it doesn't actually conflict with GitHub right now.

We should be able to run with this until https://github.com/orgs/community/discussions/23042 is resolved.

@DhruvaG2000
Copy link
Collaborator Author

@StaticRocket no no.. We don't even really need to use CODEOWNERS if you see zephyr python script, it parses the maintainers file. So there's no conflict.

@cshilwant
Copy link
Member

until https://github.com/orgs/community/discussions/23042 is resolved.

@StaticRocket I don't think they are thinking to resolve it.
I mean the thread was last responded by a GitHub team in 2019 🙂

@StaticRocket
Copy link
Member

I have faith. We've had bugs open for longer durations. :)

@cshilwant cshilwant reopened this Nov 4, 2024
@cshilwant
Copy link
Member

cshilwant commented Nov 4, 2024

Re-opening this issue (which got auto closed) since the plan is to use #32 as well to assign pull requests to default reviewers based on sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants