-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a CODEOWNERS file to auto assign reviewers #8
Comments
We should take inspiration from how it's being done in Zephyr: https://github.com/zephyrproject-rtos/zephyr/blob/main/CODEOWNERS If you see their file too has "Errors" according to github, but they don't use the "Github" way of assiging reviewers it seems like they do some amount of scripting here: https://github.com/zephyrproject-rtos/zephyr/blob/main/.github/workflows/assigner.yml which ultimately runs a python script: This script then parses https://github.com/zephyrproject-rtos/zephyr/blob/main/MAINTAINERS.yml and then auto assigns reviewers. |
Found a workflow that does the same thing the zephyr project tool was doing, but without reusing the CODEOWNERS format, so it doesn't actually conflict with GitHub right now. We should be able to run with this until https://github.com/orgs/community/discussions/23042 is resolved. |
@StaticRocket no no.. We don't even really need to use CODEOWNERS if you see zephyr python script, it parses the maintainers file. So there's no conflict. |
@StaticRocket I don't think they are thinking to resolve it. |
I have faith. We've had bugs open for longer durations. :) |
Re-opening this issue (which got auto closed) since the plan is to use #32 as well to assign pull requests to default reviewers based on sections. |
We need to add a CODEOWNERS file [1] to this repo so that we can auto assign reviewers.
[1] https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
The text was updated successfully, but these errors were encountered: