Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing Tree.NodeHighlighted message #3528

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix missing Tree.NodeHighlighted message #3528

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f07634
Fix missing NodeHighlighted message
Oct 13, 2023
12ecab2
update changelog
Oct 13, 2023
8a60b05
Update src/textual/widgets/_tree.py
robinvd Apr 3, 2024
df0ee3e
Merge branch 'main' into main
robinvd Apr 3, 2024
6be097e
Merge branch 'main' of github.com:Textualize/textual into robinvd/main
darrenburns Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## Unreleased
### Fixed
- Clicking on the last node of an new Tree would not emit NodeHighlighted message https://github.com/Textualize/textual/pull/3528
### Added
### Changed

## [0.40.0] - 2023-10-11

- Added `loading` reactive property to widgets https://github.com/Textualize/textual/pull/3509
Expand Down
2 changes: 2 additions & 0 deletions src/textual/widgets/_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,8 @@ def _new_id(self) -> NodeID:
return NodeID(id)

def _get_node(self, line: int) -> TreeNode[TreeDataType] | None:
if line < 0:
robinvd marked this conversation as resolved.
Show resolved Hide resolved
return None
try:
tree_line = self._tree_lines[line]
except IndexError:
Expand Down
Loading