Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sporadic NoMatches error reported from Header on app shutdown #4817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix sporadic NoMatches error reported from Header on app shutdown #4817

wants to merge 1 commit into from

Commits on Jul 26, 2024

  1. Fix sporadic NoMatches error reported from Header on app shutdown 

    During application shutdown, particularly when running via
`App.run_test()`, it seems that the Header's watcher callback on
`title` or `sub_title` is called while the Header's children, such as
the `HeaderTitle`, are already unmounted. This results in a
`NoMatches` error being reported.

We fix this by ignoring the `NoMatches` error, like we did with
`NoScreen` in the recent "hardedning" commit 604b04d.
    @slawek-es
    slawek-es committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ac699c4 View commit details
    Browse the repository at this point in the history