Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Support new python minor versions #768

Open
b-jazz opened this issue Nov 28, 2022 · 1 comment
Open

Support new python minor versions #768

b-jazz opened this issue Nov 28, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@b-jazz
Copy link

b-jazz commented Nov 28, 2022

🐛 Bug Report

Newer python versions like 3.10 and 3.11 should be supported.

🔬 How To Reproduce

Steps to reproduce the behavior:

  1. Note that in files like cookiecutter.json, there is no mention of 3.10 or 3.11

Code sample

Environment

  • OS: [e.g. Linux / Windows / macOS]
  • Python version, get it with:
python --version

Screenshots

📈 Expected behavior

I should be able to specify a version of 3.10 so that when I run pyupgrade, it will properly use the --py310-plus argument for example.

📎 Additional context

@b-jazz b-jazz added the bug Something isn't working label Nov 28, 2022
@b-jazz
Copy link
Author

b-jazz commented Nov 28, 2022

Hmm, this is another bug/pull-request pair that I was going to make, but I can't figure out how to make 2 separate Pull Requests with my two most recent commits to my fork. Just a fundamental misunderstanding of how PRs work on my part.

You can find the change I made here though if you want to peruse it:

b-jazz@00a52e7

I had to turn the list of python versions into strings though because [3.9, 3.10, 3.11] would get treated as [3.9, 3.1, 3.11]. It looks like there was already code in place to cast strings to integers in the jinja template, so simply putting double quotes around them in toml appears to be all you need to do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant