Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge upstream? #22

Closed
vgarleanu opened this issue May 9, 2023 · 2 comments
Closed

Merge upstream? #22

vgarleanu opened this issue May 9, 2023 · 2 comments

Comments

@vgarleanu
Copy link

Really awesome project! I'm really glad someone forked JSO!

That said, I was wondering, are there any plans on upstreaming the changes and performance fixes in this fork?
@GizmoTjaz
Copy link
Contributor

libass/JavascriptSubtitlesOctopus#138
libass/JavascriptSubtitlesOctopus#128

@ThaUnknown
Copy link
Owner

no, jassub is not something I'd consider a fork, considering i rewrote 90% of the lib from scratch, jso devs are also hell bent on some weird PR structures, which are a massive waste of time so they can go do one, i tried merging improvements but they are unreasonable

you have very litte reason to use JSO over JASSUB, JSO is slower, buggier, larger, supports less features etc etc, and everyone who used it knows that, which is why pretty much all major repositories migrated from JSO to JASSUB, including vidstack, jellyfin and others, just dim is left, but the PR is pending

@ThaUnknown ThaUnknown closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ThaUnknown @vgarleanu @GizmoTjaz