Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare/Update YTMD to use their new V2 API #82

Closed
Alipoodle opened this issue Oct 25, 2023 · 8 comments
Closed

Prepare/Update YTMD to use their new V2 API #82

Alipoodle opened this issue Oct 25, 2023 · 8 comments
Assignees
Labels
scheduled-for-next-update Service/waiting Waiting on the service to respond to queries

Comments

@Alipoodle
Copy link

YTMD Developer here, and wanted to provide a bit of a heads up notice that we're planning on doing a major update to our application.
Including a full rework of the API and Application due to some major security issues in the current build.

Work for V2 is coming near to an end now. 😋
Releases can be found here: https://github.com/ytmdesktop/ytmdesktop/releases
Full documentation for the current spec of the V2 API can be found here as well: https://github.com/ytmdesktop/ytmdesktop/wiki/v2-%E2%80%90-Companion-Server-API-v1

It was news to me that this uses the YTMD API and I hope to see it continue to work :)

@ThatGravyBoat
Copy link
Owner

I do plan to continue support its just gonna be a little hard due to there not being a socket io api for ktor the library I use for websockets in the library I created to handle all of Craftifys services https://github.com/ThatGravyBoat/jukebox, so I had to originally write my own crude version to support just what was needed for YTMD but now that YTMD uses authentication tokens instead of the old headers I need to figure out how to send those via a raw ws socket.io protocol instead

@ThatGravyBoat
Copy link
Owner

I was looking at the new API the other day due to multiple users already asking for it to be updated to v2 and noticed there was not a volume percent in the player state I was going to report this after I had actually been able to have it run in Craftify but I guess its good time as any to tell you that now.

@ThatGravyBoat ThatGravyBoat self-assigned this Dec 1, 2023
@ThatGravyBoat ThatGravyBoat added Service/waiting Waiting on the service to respond to queries and removed enhancement New feature or request labels Dec 8, 2023
@ThatGravyBoat ThatGravyBoat pinned this issue Dec 15, 2023
@Deemitry88
Copy link

still no update ?

@ThatGravyBoat
Copy link
Owner

still waiting for YTMD to update

@Tman564wsDEV
Copy link

Can you not use the preview?

@ThatGravyBoat
Copy link
Owner

ThatGravyBoat commented Jan 25, 2024

The current previews do not contain all apis needed

@Tman564wsDEV
Copy link

Oh Ok

@ThatGravyBoat
Copy link
Owner

Added in 1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scheduled-for-next-update Service/waiting Waiting on the service to respond to queries
Projects
None yet
Development

No branches or pull requests

4 participants