Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can`t install 2.2.2 x64 on windows 11 #44

Closed
Ldes opened this issue Oct 30, 2024 · 5 comments · Fixed by #52, #53 or #54
Closed

Can`t install 2.2.2 x64 on windows 11 #44

Ldes opened this issue Oct 30, 2024 · 5 comments · Fixed by #52, #53 or #54
Assignees
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@Ldes
Copy link

Ldes commented Oct 30, 2024

  • Comet Version: 2.2.2
  • TypeScript Version: 5.3.3

Description

When installing version v2.2.2 (x64) I get an error.

A JavaScript error occurred in the main process
Uncaught Exception:
Error: Cannot find module 'fluent-ffmpeg'
Require stack:

  • C:\Users\serej\AppData\Local\Comet\app-2.2.2\resources\app.asar.vite\build\main.js
    at Module._resolveFilename (node:internal/modules/cjs/loader: 1232:15)
    at s._resolveFilename (node:electron/js2c/browser_init:2:123740)
    at Module._load (node:internal/modules/cjs/loader: 1058:27)
    at c._load (node:electron/js2c/node_init:2:16955)
    at Module.require (node:internal/modules/cjs/loader:1318:19) at require (node:internal/modules/helpers:179:18)
    at Module.
    (C:\Users\serej\AppData\Local\Comet\app-2.2.2\resources\app.asar.vite\build\main.js:1:2...
    at Module._compile (node:internal/modules/cjs/loader: 1484:14)
    at Module._extensions..js (node:internal/modules/cjs/loader: 1564:10)
    at Module.load (node:internal/modules/cjs/loader: 1295:32)

Steps To Reproduce

Actual result

I get an error, the installation is interrupted

Env

  • OS Name: Microsoft Windows 11 Pro
  • OS Version: 10.0.22621 N/A Build 22621

Attach

Setup error

@Thavarshan
Copy link
Owner

Thavarshan commented Oct 31, 2024

Thank you for bringing this to my attention, and I apologise for any inconvenience this may have caused.

I’ve taken note of the concerns, and I’ll be looking into this to assess how to resolve it properly.

In the meantime if you are able to come up with a solution a PR would be greatly appreciated!

@Thavarshan Thavarshan added bug Something isn't working help wanted Extra attention is needed labels Oct 31, 2024
@Ldes
Copy link
Author

Ldes commented Oct 31, 2024

I checked the installation of the previous version, 2.2.1 x64
The installation went smoothly, without errors.

@Thavarshan
Copy link
Owner

Thanks a lot! that was actually helpful. The dependency upgrades must have affected the unpacking process. I still need to figure out how to solve this though.

@Thavarshan
Copy link
Owner

Thavarshan commented Nov 2, 2024

Hi @Ldes! Just wanted to update you. Working on a patch, will release soon!

@Thavarshan Thavarshan linked a pull request Nov 4, 2024 that will close this issue
@Thavarshan Thavarshan linked a pull request Nov 4, 2024 that will close this issue
@Thavarshan Thavarshan reopened this Nov 5, 2024
@Thavarshan Thavarshan pinned this issue Nov 5, 2024
Thavarshan added a commit that referenced this issue Nov 7, 2024
@Thavarshan Thavarshan linked a pull request Nov 7, 2024 that will close this issue
Thavarshan added a commit that referenced this issue Nov 7, 2024
@Thavarshan
Copy link
Owner

Can confirm issue has been fixed with the release v2.2.3.

@Thavarshan Thavarshan self-assigned this Nov 7, 2024
@Thavarshan Thavarshan added the enhancement New feature or request label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
2 participants