Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix texture UV mapping on tv screen model #63

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

FLOATINGCRETIN
Copy link
Collaborator

@FLOATINGCRETIN FLOATINGCRETIN commented Jan 10, 2024

Summary

closes #3


Test plan

i reloaded in-game and it looked as expected

Reproducing in-game

function _:summon

Preview

in-game -- before in-game -- after
2024-01-09_22 05 21 2024-01-09_21 53 12
2024-01-09_22 05 25 2024-01-09_21 53 15
2024-01-09_22 05 31 2024-01-09_21 58 11
2024-01-09_22 05 35 2024-01-09_21 58 16

Supplemental changes

n/a

Copy link
Owner

@TheAfroOfDoom TheAfroOfDoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small thing

@@ -1,6 +1,6 @@
{
"textures": {
"0": "minecraft:block/netherite_block"
"0": "animated_java:item/tv_screen/netherite_block"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidentally replaced vanilla texture reference with custom one -- can we fix?

Copy link
Owner

@TheAfroOfDoom TheAfroOfDoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FLOATINGCRETIN FLOATINGCRETIN merged commit 7fa7cf8 into main Jan 10, 2024
4 checks passed
@FLOATINGCRETIN FLOATINGCRETIN deleted the 3-fix-tvscreen-texture-uv branch January 10, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix texture UV mapping on tv screen model
2 participants