From 672569c7a2e7f0f85c0413b611f2b6c108d4ef3d Mon Sep 17 00:00:00 2001 From: Hugo Hamon Date: Tue, 31 Oct 2023 08:47:01 +0100 Subject: [PATCH 1/4] Remove undefined `YahooFinanceRatioProvider` ratio provider --- src/Resources/config/services.xml | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml index 58029390..df997a9e 100644 --- a/src/Resources/config/services.xml +++ b/src/Resources/config/services.xml @@ -11,7 +11,6 @@ Tbbc\MoneyBundle\PairHistory\PairHistoryManager Tbbc\MoneyBundle\Pair\Storage\CsvStorage %kernel.project_dir%/../data/tbbc_money/ratio_file_name.csv - Tbbc\MoneyBundle\Pair\RatioProvider\YahooFinanceRatioProvider Tbbc\MoneyBundle\Pair\RatioProvider\GoogleRatioProvider Tbbc\MoneyBundle\Pair\RatioProvider\ECBRatioProvider Tbbc\MoneyBundle\Formatter\MoneyFormatter @@ -42,8 +41,6 @@ %tbbc_money.reference_currency% - - From 87e5824e56cc563b134963fbedd74e34a5264413 Mon Sep 17 00:00:00 2001 From: Hugo Hamon Date: Tue, 31 Oct 2023 08:47:29 +0100 Subject: [PATCH 2/4] Remove undefined `GoogleRatioProvider` ratio provider --- src/Resources/config/services.xml | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml index df997a9e..35bb7a46 100644 --- a/src/Resources/config/services.xml +++ b/src/Resources/config/services.xml @@ -11,7 +11,6 @@ Tbbc\MoneyBundle\PairHistory\PairHistoryManager Tbbc\MoneyBundle\Pair\Storage\CsvStorage %kernel.project_dir%/../data/tbbc_money/ratio_file_name.csv - Tbbc\MoneyBundle\Pair\RatioProvider\GoogleRatioProvider Tbbc\MoneyBundle\Pair\RatioProvider\ECBRatioProvider Tbbc\MoneyBundle\Formatter\MoneyFormatter @@ -41,8 +40,6 @@ %tbbc_money.reference_currency% - - From ae6aaaa22964cfdb63cc3624fa385a1b4aa67433 Mon Sep 17 00:00:00 2001 From: Hugo Hamon Date: Tue, 31 Oct 2023 08:51:08 +0100 Subject: [PATCH 3/4] Add changelog file for version 6.x --- change-log-6.0-and-versions.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 change-log-6.0-and-versions.md diff --git a/change-log-6.0-and-versions.md b/change-log-6.0-and-versions.md new file mode 100644 index 00000000..5b1662d7 --- /dev/null +++ b/change-log-6.0-and-versions.md @@ -0,0 +1,17 @@ +Versions from 6.0 +----------------- + +### 2023-10-31 : updates for 6.0.0 version + +**New features** + +**BC breaking changes** + +- Drop `YahooFinanceRatioProvider` ratio provider support + - Remove `tbbc_money.ratio_provider.yahoo_finance.class` container parameter + - Remove `tbbc_money.ratio_provider.yahoo_finance` service definition +- Drop `GoogleRatioProvider` ratio provider support + - Remove `tbbc_money.ratio_provider.google.class` container parameter + - Remove `tbbc_money.ratio_provider.google` service definition + +**Internal Developer things** From d3f7358ff37ad3251b1f196b0633d111290abf61 Mon Sep 17 00:00:00 2001 From: Hugo Hamon Date: Tue, 31 Oct 2023 09:00:49 +0100 Subject: [PATCH 4/4] Update `README` file --- README.md | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index a385c572..27f4f93f 100644 --- a/README.md +++ b/README.md @@ -449,20 +449,32 @@ class IndexController extends Controller ### Change the ratio provider -The ratio provider by default is base on the service 'tbbc_money.ratio_provider.ecb' +The ratio provider by default is base on the service `tbbc_money.ratio_provider.ecb`. -This bundles contains three ratio providers : +* `tbbc_money.ratio_provider.ecb` ratio provider is based on the data provided here https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml -* tbbc_money.ratio_provider.ecb based on the data provided here https://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml -* tbbc_money.ratio_provider.yahoo_finance based on the Yahoo finance APIs https://developer.yahoo.com/ (yahoo does not provide this api anymore) -* tbbc_money.ratio_provider.google based on the https://www.google.com/finance/converter service (google does not provide this api anymore) +You can write your own ratio provider by creating and custom class that implements the `RatioProviderInterface` interface. -You can change the service to use in the config.yml file : +```php +namespace App\Money; + +use Tbbc\MoneyBundle\Pair\RatioProviderInterface; + +final class YourRatioProviderService implements RatioProviderInterface +{ + public function fetchRatio(string $referenceCurrencyCode, string $currencyCode): float + { + // implement your custom logic here + } +} +``` + +You can change the service to use in the `config/packages/tbbc_money.yaml` file : ``` tbbc_money: [...] - ratio_provider: tbbc_money.ratio_provider.google + ratio_provider: App\Money\YourRatioProviderService ``` ### Additional rate providers from Exchanger