Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket Client Throws Exception to Stop Subscription After Runtime Exceeded #33

Open
TheCookieLab opened this issue Mar 14, 2018 · 0 comments

Comments

@TheCookieLab
Copy link
Owner

TheCookieLab commented Mar 14, 2018

Exceptions should be for exceptional circumstances rather than normal logic flow. As the code stands right now, if it doesn't throw an exception, the subscription will "end" but the program will hang. Look into another method for stopping subscriptions as this will remove several code smells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant