Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew: install correctly on apple silicon #155

Merged
merged 1 commit into from
May 25, 2022

Conversation

damonbreeden
Copy link
Contributor

brew expects to see files in /opt/homebrew on Apple silicon so check for that and set the paths accordingly

@damonbreeden damonbreeden requested a review from TheKevJames as a code owner May 6, 2022 22:34
Copy link
Owner

@TheKevJames TheKevJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for tackling this. :)

@TheKevJames TheKevJames merged commit 96225d4 into TheKevJames:master May 25, 2022
@sp-ricard-valverde
Copy link

Late to the party, but seems that $::facts[processors][models] is not always available.
I've found the issue when running on GitHub CI macOS workers but I can reproduce the same locally(processor fact has no modules key)

@TheKevJames
Copy link
Owner

@sp-ricard-valverde shoot. Anything special about those systems? Or perhaps any other keys in processor we might be able to fall back to checking?

@sp-ricard-valverde
Copy link

Nothing special that I could see. It may be related to OS permissions, Full Disk Access, ... dunno.
I ended up successfully implementing the has_arm64 fact from PR #154 as processors did not contain relevant information.
There are already facts regarding architecture though(with values x86_64, arm64) that seem to be pretty reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants