Fix setting of ARCH_INDEPENDENT based on INTERFACE_LIBRARY property #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PROJECT_ARCH_INDEPENDENT is not set by the user, PackageProject will attempt to set this automatically depending on whether the target is an INTERFACE_LIBRARY or not. However, this auto-detection currently does not work due to an error in the CMake logic.
|
The correct logic was already being used in another part of this file. See https://github.com/TheLartians/PackageProject.cmake/pull/39/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR93. The fix was to use that correct logic in all other places in the file. |
TheLartians
approved these changes
Jan 17, 2024
|
Fix is released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PROJECT_ARCH_INDEPENDENT is not set by the user, PackageProject will attempt to set this automatically depending on whether the target is an INTERFACE_LIBRARY or not.
However, this auto-detection currently does not work due to an error in the CMake logic.