Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce lint rules with eslint - Also add a pipeline to check lint on each PR #38

Open
MadhavBahl opened this issue Oct 4, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@MadhavBahl
Copy link
Member

No description provided.

@fastboot
Copy link
Contributor

fastboot commented Oct 4, 2021

Hey, @MadhavBahl would like to work on this can you assign it to me? Also what all lint rules should be enforced if you can list them that would be helpful. Thanks!

@MadhavBahl
Copy link
Member Author

Thanks @fastboot ,
We can go ahead with the usual AirBnB config

@fastboot
Copy link
Contributor

fastboot commented Oct 7, 2021

Hey, @MadhavBahl have raised a PR had a couple of question let me know what you think?

  1. Should I add lint checks for push as well?
  2. For now I used the To check syntax, find problems, and enforce code style option, let me know if you just need to check and find problems and not enforce code style.

Here's the PR have a look: Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants