Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack documentation URL #98

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Conversation

LDannijs
Copy link
Contributor

Summary

Add a URL to The Things Industries documentation of integrations
@felixheins wanted this for the Partner Portal

Changes

  • add stack-documentation-url
  • Update broken URLs

Notes for Reviewers

@KrishnaIyer is this properly implemented?

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible, they don't break existing deployments.
  • Testing: The changes are tested.
  • Documentation: Relevant documentation is added or updated.

@github-actions github-actions bot added the needs/triage We still need to triage this label Aug 14, 2024
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks ok to me. Some of these vendors (Ex: iot-factory.yml) don't have the new URL. Is that intended?

LogoURL string `yaml:"logo-url"`
InfoURL string `yaml:"info-url"`
DocumentationURL string `yaml:"documentation-url"`
StackDocumentationURL string `yaml:"stack-documentation-url"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Things Stack; so maybe TTSDocumentationURL

@LDannijs
Copy link
Contributor Author

Yes some don't because they don't have any documentation.

@KrishnaIyer KrishnaIyer merged commit 4e77ff3 into TheThingsNetwork:master Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/triage We still need to triage this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants