Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status component and improve typing definitions #25

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Add status component and improve typing definitions #25

merged 3 commits into from
Jan 23, 2025

Conversation

tschanomis
Copy link
Contributor

@tschanomis tschanomis commented Jan 23, 2025 •
edited by TheoBrigitte
Loading

  • Move Status logic to statusComponent, and refactor
  • Improve typing definitions
  • Replace single quotes with double quotes

TheoBrigitte
TheoBrigitte reviewed Jan 23, 2025
View reviewed changes
Copy link
Owner

@TheoBrigitte TheoBrigitte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks for all the fixing!

Just 2 very minor style remarks. Also a nicer PR title and some description would be appreciated.

@TheoBrigitte TheoBrigitte changed the title Fix branch Improve status component and typing definitions Jan 23, 2025
@TheoBrigitte TheoBrigitte changed the title Improve status component and typing definitions Add status component and improve typing definitions Jan 23, 2025
@TheoBrigitte TheoBrigitte merged commit 37520e9 into TheoBrigitte:main Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheoBrigitte TheoBrigitte TheoBrigitte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tschanomis @TheoBrigitte