Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golem_utils_server & golem_utils_ui don't have full coverage by default #1013

Closed
1 task
ColinFay opened this issue Mar 29, 2023 · 4 comments
Closed
1 task

Comments

@ColinFay
Copy link
Member

User - Validation

  • When I add the utils_ui and utils_server with the tests, the code coverage for these two files is 100%

Dev - Tech

Right now it's:

#> R/golem_utils_server.R: 77.78%
#> R/golem_utils_ui.R: 87.94%
@ilyaZar
Copy link
Contributor

ilyaZar commented Apr 2, 2023

Works in a fresh golem::create_golem() when running golem::use_utils_ui(with_test = TRUE) and golem::use_utils_server(with_test = TRUE) from R/01_start.R:

image

@ilyaZar
Copy link
Contributor

ilyaZar commented Jul 5, 2023

just leaving a note that this can be closed.

But I am wondering, no matter how "aggressively" I keep linking PRs to issues with the #, or adding a "Refs: #some_number" inside a commit, I never get them automatically closed ...

Neither I am able to consistenly have the "dot in the circle"-symbol in the pull-request section:

image

In the above snippet, the second line has that symbol while the other does not. Do you have an idea why @ColinFay?

@ArthurData
Copy link
Member

ArthurData commented Dec 15, 2023

Hello @ilyaZar :)
Perhaps it depends on how the branches are opened? From the github interface or directly from Rstudio (or VsCode?)

To be tested for future devs.

Can I close here?

@ilyaZar
Copy link
Contributor

ilyaZar commented Dec 15, 2023

@ArthurData I think it's been merged so from my side closing makes sense

I create branches from the local repository, not from the github fork, but I'll try tthe other way round some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants