Fix 1121 broken use readme test #1122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build_readme causes an error if run non-interactively hence the skip_if_not(interactive()) is added in the first place after deleting build_readme() the test passes non-interactively though
ColinFay
reviewed
Feb 28, 2024
| # Check if file exists | ||
| expect_true(file.exists(golem_sys("utils/empty_readme.Rmd"))) | ||
| # Remove file via check_overwrite setting overwrite=TRUE | ||
| check_overwrite(TRUE, golem_sys("utils/empty_readme.Rmd")) |
There was a problem hiding this comment.
Issue here is that the file will be removed from the installed package on the machine, so I'll rewrite this a bit :)
|
Cherry picked in #1131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1121
Make all test for
test-use_readme.Rpass successfully in non-interactive mode.Additionally, test a previously untested corner case.
Improves codecov for
use_readme.Rfrom 34.29% to 100%