Fixed handling of categorical features. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBury
approved these changes
May 15, 2023
| @@ -337,18 +337,15 @@ def _fit(self, X_raw, y, sample_weight=None): | |||
| # because the columns are dynamically created/rejected | |||
| X = X_raw | |||
|
|
|||
| X = np.nan_to_num(X) | |||
| y = np.nan_to_num(y) | |||
| X = X.apply(np.nan_to_num) | |||
There was a problem hiding this comment.
good catch, I, wrongly, kept the boruta initial version. This will indeed mess up the data types. I will probably change it to X.fillna(0) and y.fillna(0) rather than apply (slow) and nan_to_num (numpy, while pandas methods are more suited).
| X = X.apply(np.nan_to_num) | ||
| if not isinstance(y, pd.Series): | ||
| y = pd.Series(np.nan_to_num(y)) | ||
| else: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18, closes #19
I described my changes here.
Leshy changes.pdf
I would be glad if you would take a look at my changes. Those will fix mentioned issues. If you want me to change anything feel free to say, thanks.