We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The MinRedundancyMaxRelevancy class adds the target column to X.
MinRedundancyMaxRelevancy
target
X
y
The ``MinRedundancyMaxRelevancyfit method should compute the necessary values and return them without modifying the input DataFrameX`.
fit method should compute the necessary values and return them without modifying the input DataFrame
The input DataFrame X is being modified by having the target column appended to it after calling MinRedundancyMaxRelevancy fit method.
The text was updated successfully, but these errors were encountered:
This is not happening with a custom relevance_func and redundancy_func setup
Sorry, something went wrong.
d4ad5aa
Good catch, I added the missing copy() to prevent modifying the input pandas DF when fitting the selector
copy()
ThomasBury
No branches or pull requests
Description
The
MinRedundancyMaxRelevancy
class adds thetarget
column toX
.Steps to Reproduce
MinRedundancyMaxRelevancy
classX
and a target seriesy
.MinRedundancyMaxRelevancy
fit function withX
andy
as inputs.target
column is unexpectedly added to DataFrameX
.Expected Behavior
The ``MinRedundancyMaxRelevancy
fit method should compute the necessary values and return them without modifying the input DataFrame
X`.Actual Behavior
The input DataFrame
X
is being modified by having thetarget
column appended to it after callingMinRedundancyMaxRelevancy
fit method.The text was updated successfully, but these errors were encountered: