Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of htmlFormatConvert #331

Open
ThosRTanner opened this issue May 12, 2023 · 0 comments
Open

Review use of htmlFormatConvert #331

ThosRTanner opened this issue May 12, 2023 · 0 comments

Comments

@ThosRTanner
Copy link
Owner

ThosRTanner commented May 12, 2023

What this does is

  1. Convert < and > to 'unlikely to occur' strings
  2. run an undocumented function to convert from text/html to text/unicode mime types
  3. undo the 1st conversion

I think we just want to convert utf8 to unicode ? is there an equivalent. the replacing of < and > and then unreplacing them does have dangers.

It is also worth noting that anything coming in from atom/rss feeds has already been through TextDecoder. It is likely that html scraping has also been treated like that (needs checking), so it is likely to be only useful for NNTP feeds (which should be utf8) - and that could probably also use the TextDecoder method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant