Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print: charts on data page have page break #95

Open
michaelwood opened this issue Feb 9, 2022 · 5 comments
Open

Print: charts on data page have page break #95

michaelwood opened this issue Feb 9, 2022 · 5 comments
Assignees
Labels
bug An error has occurred or something that is designed to work isn't working prerequisite for live Must be fixed before site goes live Priority Highly prioritised for iterative improvements

Comments

@michaelwood
Copy link
Member

For some reason the charts on the data page are not respecting the page break rules like the ones on the home page are. Must be some kind of difference in what css rules are applied.

@michaelwood michaelwood added bug An error has occurred or something that is designed to work isn't working prerequisite for live Must be fixed before site goes live labels Feb 9, 2022
@michaelwood
Copy link
Member Author

Can't always reproduce this problem, maybe a race condition on the css loading

@mariongalley mariongalley added the Priority Highly prioritised for iterative improvements label Feb 24, 2022
@codemacabre
Copy link
Contributor

codemacabre commented Nov 21, 2022

After a bit of investigation, page breaks seem to be working as expected. There is a page-break-after: avoid; after headings which might need some work, but the charts are only breaking to new pages when there's no space on the current page.

The reason there's a difference between homepage and data page, and why it's not always reproducible, is because the homepage totals charts are larger, which is why most of them break to new pages, whereas the data page individual charts only have data per individual dataset selected, so will always be smaller which allows space for multiple on the page.

If we still want to have consistent page breaks, we'll need to force a page break after every chart, which will affect both homepage and data pages. @michaelwood @mariongalley Is this what we want?

I hadn't seen a chart being broken between pages, so misunderstood the problem. Ignore this ☝🏼; I've now reproduced the problem and am on the case...

@codemacabre
Copy link
Contributor

@mariongalley This appears to largely be a bug in Chrome where page breaks aren't working as expected. There may be a workaround but will likely take longer than originally anticipated.

@mariongalley
Copy link

mariongalley commented Nov 24, 2022

@codemacabre OK, I think it's lower priority than the bugs raised on new org pages and widgets so happy to leave it for now.

Would it be helpful if I added the important bugs to the "within a few days" priority on the project board?

@michaelwood
Copy link
Member Author

Current work around is to use firefox. I think the print style rules may have a issue in the 360-ds as the implementation of the print style looks correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error has occurred or something that is designed to work isn't working prerequisite for live Must be fixed before site goes live Priority Highly prioritised for iterative improvements
Projects
None yet
Development

No branches or pull requests

3 participants