Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Include Publisher Logos on Publisher Dashboard #118

Closed
mariongalley opened this issue Jul 29, 2022 · 4 comments
Closed

Include Publisher Logos on Publisher Dashboard #118

mariongalley opened this issue Jul 29, 2022 · 4 comments
Assignees
Labels
Prerequisite for Registry depreciation Issues that need to be resolved before Data Registry can be replaced by Data Quality Dashboard

Comments

@mariongalley
Copy link

This is required to satisfy #115

@KDuerden KDuerden added the Prerequisite for Registry depreciation Issues that need to be resolved before Data Registry can be replaced by Data Quality Dashboard label Aug 4, 2022
@KDuerden
Copy link
Collaborator

KDuerden commented Aug 4, 2022

My preferred placing would be right aligned at the same level as the publisher name, on the publisher detail page.

image

This would mean the publisher list would not have the logo showing, but as the design doesn't really allow for adding an image, I think that is ok.

@KDuerden
Copy link
Collaborator

Not all funders have a logo, or we don't get permission to use it.

The update to add the logo to the Dashboard currently has a link to the funder website as part of the logo, but when that is missing, it has a missing image icon instead.

For example

image

Is there a way to make this fail more elegantly when there isn't a logo?

@mariongalley
Copy link
Author

@codemacabre See Katherine's update above

@mariongalley
Copy link
Author

@codemacabre This is fixed in dev, thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Prerequisite for Registry depreciation Issues that need to be resolved before Data Registry can be replaced by Data Quality Dashboard
Projects
None yet
Development

No branches or pull requests

3 participants