Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback images #55

Open
rodericj opened this issue Apr 24, 2019 · 1 comment
Open

Fallback images #55

rodericj opened this issue Apr 24, 2019 · 1 comment
Assignees

Comments

@rodericj
Copy link

We need to have a fallback image incase any of a number of things happens.

  1. Image can't be fetched at this time
  2. Image URL is not included in the metadata (never set or whatever)
  3. Something else?

We had chatted during Coffup today and we're looking to de-emphasize foursquare's image API usage. As a larger initiative to that end we need to implement this fallback. We had the suggestion of using the group image which is certainly possible, however we would need to have #33 or some subset of that merged in.

@mcritz has a concept of "Image of last resort" in which the group image is also not fetch able and this likely needs to be some image that is packaged in the binary. Some Coffee glyph or something: ☕️

@rodericj
Copy link
Author

Regarding the point above about #33 being merged in, I'd made #61 and it's been merged in. This is the infra to actually fetch the list of groups. The appropriate image URLs should be in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants