Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update this addon to a more modern approach #30

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kiwiupover
Copy link

@kiwiupover kiwiupover commented Aug 8, 2021

  1. Remove the need to use Ember directly.
  2. Use ember-auto-import to use mockdate.
  3. Update ember-cli and ember to the latest version.
  4. Added github actions to run CI.
  5. Update tests to use modern ember idioms.

@@ -20,16 +19,13 @@ const { set, reset } = MockDate || {
* https://github.com/BackburnerJS/backburner.js/pull/264
*/
const freezeDateAt = (...args) => {
trySet(Ember, 'run.backburner._platform.now', () => originalDate());
trySet(run, 'backburner._platform.now', originalDate.now());
Copy link

@jrjohnson jrjohnson Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like backburner tries to call this as a function, so now should be passed here without calling it.

Suggested change
trySet(run, 'backburner._platform.now', originalDate.now());
trySet(run, 'backburner._platform.now', originalDate.now);

@kiwi-josh
Copy link
Contributor

Abit has changed since this PR was opened, therefore I've opened another one that is heavily inspired by these changes, but is up to date against the last ember version (4.4)
#35

(I've also made sure this comment is taken into account: #30 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants