Can't quit using cmd-q with only dialog

[jsoref]

macOS 10.13.1
TigerVNC 1.8.0

I should be able to Quit using cmd-q (or the menu item).
I can't because I haven't connected yet.
Instead, I have to use a mouse to hit the red gem (cmd-w doesn't work either...)

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[CendioOssman]

So it works once you are connected?

I don't have any macOS machines here right now, but I can have a look once I do.

[jsoref]

I'm not sure actually. I think it does....

[CendioOssman]

I see this with the official builds, but not my own builds.

@bphinz, I think you need to debug this. What version of FLTK are you using?

[bphinz]

I believe that it's 1.3.4 but I will double check tonight. @CendioOssman, what version of OS X are your builds produced on?

[CendioOssman]

We have our own build environment using gcc 5 and OS X 10.6 SDK.

[bphinz]

I'm using the 10.6 SDK as well. I'll poke around tonight and see if anything is amiss.

[CendioOssman]

We're using an older FLTK (basically 1.3.3 plus patches). Might be a later bug in FLTK...

[bphinz]

Definitely using 1.3.4. Can you send me the patches you're applying?

[CendioOssman]

I had a look and all our patches are just backports of stuff that is included in 1.3.4.

I'll try to do a test with 1.3.4 here and see if I get the same issue.

[CendioOssman]

Yeah, I'm getting the same issue after upgrading to FLTK 1.3.4. So it seems to be a bug there.

[CendioOssman]

I don't really have time to poke around with this right now. Could you check with the fltk devs, @bphinz?

[bphinz]

Yes, I'll try to chase this down. I did a cursory check and didn't see any reports or google hits, but I'll post a question on the fltk dev forum and/or file a bug ticket.

[bphinz]

I did find this in the 1.3.4rc3 changelog:

CHANGES IN FLTK 1.3.4rc3				RELEASED: Oct 31 2016

	Bug fixes and other improvements

	- Fix string truncation in fluid (STR #2722 continued).
	- MacOS: fix a small problem where the Command-Quit menu hotkey
	  may not work if Fl_Native_File_Chooser is used before any
	  window is shown.

But I haven't found any reference to the related changeset. Will probably have to do a diff between 1.3.4rc2 and 1.3.4rc3 to see what changed and if there's any relation to what we're doing (obviously we're not using a native file chooser before displaying any other window).

[CendioOssman]

An luck pinpointing this?

[bphinz]

No, I've been diffing 1.33 vs 1.34. Here is the commit mentioned in the 1.3.4rc3 changelog: fltk/test-only@c3a098b Maybe we need to add an fl_open_display? I haven't found what changed that would make 1.3.4 require this when 1.3.3 didn't though...

…

On Mon, Feb 5, 2018 at 4:04 AM, Pierre Ossman (Work account) < ***@***.***> wrote: An luck pinpointing this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#569 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHnWbfy8bjsRE3I3x9bXUn2MNb4FV4ZNks5tRsQ2gaJpZM4RTKv6> .

[CendioOssman]

Maybe. Have you tried calling it early and see what happens?

And did you ask on the FLTK mailing list?