Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpdef methods that return C types like Stream.get_file_position must have an except clause or the exception won't propagate #5

Open
Keithcat1 opened this issue Mar 2, 2022 · 1 comment

Comments

@Keithcat1 Keithcat1 changed the title cpdef methods that don't return Python objects must have an except clause or the exception won't propagate cpdef methods that return C types like Stream.get_file_position must have an except clause or the exception won't propagate Mar 2, 2022
@Timtam
Copy link
Owner

Timtam commented Mar 2, 2022

thank you. I would have noticed as soon as a test tries to handle exactly such a situation. I'll leave it open as a reminder until i can be sure to have fixed the corresponding methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants