Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is Tinder/Scarlet alive? #119

Open
ilyaklyukin opened this issue Nov 19, 2019 · 9 comments
Open

is Tinder/Scarlet alive? #119

ilyaklyukin opened this issue Nov 19, 2019 · 9 comments

Comments

@ilyaklyukin
Copy link

ilyaklyukin commented Nov 19, 2019

Is Tinder/Scarlet alive?

  • Last commit in master was 4 months ago
  • PR are not merged
  • v.0.2.x is not published (I have to use 0.2.5-SNAPSHOT).

Who is responsible for approving PRs? I've spent a lot of time for adding this library in my project, but now I'm stuck with some critical issues:

  • can't initiate reconnection when server closes WS connection (lifecycleRegistry.onNext(LifecycleState.Started) does nothing in this case).
  • in case of no network (turned off WiFi), scarlet continues to reconnect even is app is paused (and establishes connection in foreground when wifi is swithed on!)

I much appreciate greate work that was done here, gson adapter, coroutines, retrofit-like config, but now I'm very doubt of using it in production.

@aaronweihe
Copy link
Collaborator

0.2.x is still experimental. to grab a non-snapshot version, 0.2.4 is still available via jitpack. Hopefully I'll have time to publish 0.2.5 soon.

Scarlet powers Tinder's messages/matches every single minute. If you have issues integrating with it, can you create separate issues or link to existing issues, so we can triage those tickets and prioritize bug fixing.

@ilyaklyukin
Copy link
Author

@aaronhe42 thanks for the response.
1st issue seems like described here (thus I use not lifecycleOnwer)
#118

2nd is similar to it, the difference only that when our backend closes WS connection with special code (so client knows the reason), I can't initiate reconnection from the client with the call
(nothing happens):
lifecycleRegistry.onNext(LifecycleState.Started)

#80

@ilyaklyukin
Copy link
Author

1st (#118) I hope to be fixed with PR
#58 - but nobody merges it..

@ilyaklyukin
Copy link
Author

@aaronhe42 any progress? who could merge into 0.2.x , for example,
#58 ?

@ilyaklyukin
Copy link
Author

any news? no commits

@SteinerOk
Copy link

Waiting for updates in 0.2.x branch
Dreams about migration from rxJava to Coroutines

@muhammadFawzy
Copy link

is there any updates about #80 ?

@cfva14
Copy link

cfva14 commented Sep 27, 2020

Guys I think we should create a new web socket library based on this one. It's ridiculous how they don't care about this project. I have seen so many good PRs and issues with no answers.

@thesultanster
Copy link

Seriously what is going on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants