Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lib Cleaning - Cleaning up internal API #31

Open
mblenczewski opened this issue Apr 17, 2019 · 1 comment
Open

Lib Cleaning - Cleaning up internal API #31

mblenczewski opened this issue Apr 17, 2019 · 1 comment
Labels
refactor Marks an issue as a refactoring issue; it is not critical by itself.

Comments

@mblenczewski
Copy link
Contributor

mblenczewski commented Apr 17, 2019 •
edited
Loading

Affecting mainly Connection.cs and UdpConnection.cs (that ive seen so far). In internal methods there are remenants of a write lock (in parameters and unused fields or properties). Im assuming this is from the now-obsolete connection locking feature. These should be removed (or at least marked Obsolete) for the next release, so as to simplify and clean up the internal API.
@mblenczewski mblenczewski added the refactor Marks an issue as a refactoring issue; it is not critical by itself. label Apr 17, 2019
@Toemsel
Copy link
Owner

Toemsel commented Apr 17, 2019

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Marks an issue as a refactoring issue; it is not critical by itself.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Toemsel @mblenczewski