Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix deployment step in CI workflow #7

Merged
merged 2 commits into from
Jan 18, 2024
Merged

ci: fix deployment step in CI workflow #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eaa86d
ci: fix deployment step in CI workflow
0xmichalis Jan 18, 2024
b4a9d83
ci: disable workflow temporarily for PRs
0xmichalis Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ name: faucet tests
on:
push:
branches: [main]
pull_request:
branches: [main]

jobs:
test:
Expand Down Expand Up @@ -61,3 +59,10 @@ jobs:

- name: Deploy contracts
run: yarn hardhat deploy --network hardhat
# This shouldn't be needed but because forking
# mode is always enabled in the hardhat config
# we need to define the mumbai URL here.
# TODO: Make forking mode configurable and
# remove this from here.
env:
MUMBAI_URL: ${{ secrets.MUMBAI_RPC_URL }}