Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier public apis for Conditional statments + Marginalization mask #27

Open
khosravipasha opened this issue Oct 15, 2020 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@khosravipasha
Copy link
Contributor

khosravipasha commented Oct 15, 2020

  1. Easy CON API
    Currently user has to manually call MAR twice to get conditionals. Have some api like this:
conditional(circuit::ProbCircuit,  data::DataFrame,  q_indices)

Where q_indices give indexes of variables in q for each datapoint (all variables mentioned in q[i] should NOT be missing in the correspoding data[i]). In the end we are computing p( q | x^o) for each data point where x^o is all observed variables except the ones in q.

  1. MAR with Marginalization mask
    Makes sense to add another API to marginalize even over observed varibles. (for example above we need p^o but x^o, q is observed). This helps to avoid copying data for each query.

initial attempt here: master...cond

@khosravipasha khosravipasha added enhancement New feature or request good first issue Good for newcomers labels Oct 15, 2020
@khosravipasha khosravipasha added this to the Version 0.3 milestone Oct 15, 2020
@khosravipasha khosravipasha added the help wanted Extra attention is needed label Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant