WIP support split service #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonagle
reviewed
Dec 19, 2024
|
|
||
| // Is that modification splitting the service in two, instead of just having a detour | ||
| // If true, a `secondary_shape_id` should be provided in TransitSelectedTripsExtension | ||
| optional bool is_splitting_service = 4; |
There was a problem hiding this comment.
Nit: would no_through_travel through_travel_prohibited work? it feels a bit clearer to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support split service by adding
I think this might be ok for our usecase, but that does mean that there can be only a single split service modification. I don't think that will be ok for the general spec.