Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Don't load all receipt modals on load, only on click #358

Open
TreyWW opened this issue Apr 28, 2024 · 5 comments
Open

bug: Don't load all receipt modals on load, only on click #358

TreyWW opened this issue Apr 28, 2024 · 5 comments
Labels
awaiting-detail bug enhance Add on to an existing feature; or add something that isnt a new feature for example a test case

Comments

@TreyWW
Copy link
Owner

TreyWW commented Apr 28, 2024

What version of MyFinances are you currently using?

v0.4.0

What device type are you currently facing the issue on?

No response

Describe the bug

At the moment all modals get fetched on load, we should really just be only fetching modal on click like the rest of the app

@TreyWW TreyWW added bug frontend enhance Add on to an existing feature; or add something that isnt a new feature for example a test case labels Apr 28, 2024
@hussein-mamane
Copy link
Contributor

hello @TreyWW , I am new to OSS, I am a first-timer, I just setup MyFinances , I am now good to go, give me an image please so I understand the Issue.
Thanks a lot.

@TreyWW
Copy link
Owner Author

TreyWW commented Jul 12, 2024

Hey @hussein-mamane,

Pretty much on the dashboard/receipts/ page we load all modals on load; instead we want to only load them when the user clicks either preview button. If you don't have knowledge of HTMX or django views this may not be the best first feature, as it's pretty complex with HTMX. You can look at our other views if you want to give it a shot.
image

on load you can see all images trying to be rendered, before we even preview them
image

@hussein-mamane
Copy link
Contributor

I know django but not htmx, I will look for another issue.
thanks.

@TreyWW
Copy link
Owner Author

TreyWW commented Jul 12, 2024

If you have discord you can join our server, we have quite a lot of features listed only on there. We can have better discussions about them too.

@hussein-mamane
Copy link
Contributor

I'll be there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-detail bug enhance Add on to an existing feature; or add something that isnt a new feature for example a test case
Projects
None yet
Development

No branches or pull requests

2 participants