Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing hints #60

Open
devos50 opened this issue Nov 11, 2020 · 2 comments
Open

Add typing hints #60

devos50 opened this issue Nov 11, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@devos50
Copy link
Contributor

devos50 commented Nov 11, 2020

Since the code of AnyDex is particularly error-prone (a single mistake can result in lost money), it would be helpful to add typing hints throughout the code base. #58 did add typing to some files, but there are many files left that require typing to be implemented.

@devos50 devos50 added the enhancement New feature or request label Nov 11, 2020
@Solomon1732
Copy link
Contributor

If I open a PR to close this issue (either partially or wholly), should the commit history be one commit per (sub)module?

@devos50
Copy link
Contributor Author

devos50 commented Feb 23, 2021

I would suggest making separate commits and PRs to keep the number of changes small and maintainable 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants