Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TaskManagers to manage TaskManagers #1308

Open
qstokkink opened this issue Jul 26, 2024 · 1 comment · May be fixed by #1328
Open

Allow TaskManagers to manage TaskManagers #1308

qstokkink opened this issue Jul 26, 2024 · 1 comment · May be fixed by #1328
Assignees
Labels
priority: low Should be addressed at some point in the future

Comments

@qstokkink
Copy link
Collaborator

Regarding the Tribler code, I see several instances of "something with a TaskManager" that manages "something with a TaskManager".

The procedure for managing these things is:

  1. Create a child ("something with a TaskManager") in the parent ("something with a TaskManager") code.
  2. Wait for shutdown.
  3. Destroy the children.

Each child waits for shutdown (by the parent) itself. However, if there is a link with the parent, it needs to make sure that the parent has not shut down yet.


My proposal is to create a TaskManager.register_taskmanager() that simply shuts down the given task manager on shutdown. This avoids the above explicit management by downstream code bases.

@qstokkink qstokkink added the priority: low Should be addressed at some point in the future label Jul 26, 2024
@qstokkink
Copy link
Collaborator Author

I think we can include this in the IPv8 3.0 release.

@qstokkink qstokkink self-assigned this Nov 21, 2024
@qstokkink qstokkink linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Should be addressed at some point in the future
Development

Successfully merging a pull request may close this issue.

1 participant