chore (lfgsolo): clean up #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce script diff from master. LFG Solo was literally 90% core edit with a on off bool in a custom script folder. It made no sense. Time to revisit the idea of a cleanup Remove Lgf_Solo.cpp from custom script folder Remove announcement on login and in conf Move SoloLFG.Enable bool to the exsisting LFGPlayerScript::OnLogin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Target branch(es): 3.3.5-lfgsolo
Issues addressed: Fixes #
Tests performed: (Does it build, tested in-game, etc)
Known issues and TODO list: