Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (passive_anticheat): clean up and build fix #133

Conversation

acidmanifesto
Copy link
Contributor

@acidmanifesto acidmanifesto commented Feb 19, 2024

Changes proposed:

  • White Space Fix thanks to @Aokromes for identifying
  • .c_str() to fix debian build
  • add logging to auto jail and jail command as a form of spacer before casting spells after teleporting.

Target branch(es): 335-passive_anticheat

Issues addressed: Fixes # #132
Possible Fix # #124

Tests performed: (Does it build, tested in-game, etc)

Known issues and TODO list:

  • [ ]
  • [ ]

@acidmanifesto acidmanifesto changed the base branch from 3.3.5 to 3.3.5-passive_anticheat February 19, 2024 18:34
@acidmanifesto
Copy link
Contributor Author

if possible. Are you able to test and report any compile issues @DykeRz or @Aokromes
Also can you confirm if the crash is happening on your end @CraftedRO

@acidmanifesto acidmanifesto marked this pull request as ready for review February 19, 2024 19:02
@Aokromes
Copy link
Member

[100%] Built target worldserver

real 13m14.884s
user 46m31.323s
sys 1m47.208s

it builds on debian 11.

@CraftedRO
Copy link
Contributor

Crash still occured.

@acidmanifesto
Copy link
Contributor Author

Crash still occured.

do you have a crash log you can provide using this pr? at this point i can't seem to replicate any crashing further, maybe the log can provide further information i am not seeing to see what the difference is between your end and mines.

@acidmanifesto
Copy link
Contributor Author

Crash still occured.

I went ahead and did a load order change up. can you test again at your earlier convince please?

@CraftedRO
Copy link
Contributor

the new crashlog was attached to the issue, for earlier question.
I will test changes again soon.

@CraftedRO
Copy link
Contributor

Tested again, still crash, sorry.

@acidmanifesto
Copy link
Contributor Author

closing for now. will reopen for build fix debian 11 only. will investigate the crash in a seperate pr.

@acidmanifesto acidmanifesto deleted the buildfixitagainsey branch February 21, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants