Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traps with specific_trap === 0 fail to encode #247

Open
peterfaller opened this issue Sep 13, 2016 · 0 comments
Open

Traps with specific_trap === 0 fail to encode #247

peterfaller opened this issue Sep 13, 2016 · 0 comments

Comments

@peterfaller
Copy link

The default value for specific_trap is 0; but the test for whether the specific trap has been supplied is simply 'if (arg.specific_trap) this.specific_trap = arg.specific_trap;' (lib/protocol/pdu.js:294). The test fails if specific_trap is 0, and results in a failure to encode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterfaller