Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/azpi arte/loginpage #68

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

azpi-arte
Copy link
Contributor

Tracking Info

Resolves #34

Changes

  • Created a log in page and a log in form. The log in page is called 'login' and is in the frontend app folder.
  • The login form has an email and password input. User can only submit the form when the inputs are valid and the submit button is not loading/already submitting
  • Till the 'create user' page form is created, right now, the form assumes any valid password is correct.
  • The 'remember me' checkmark remembers it state after a refresh. When the checkmark is checked and the form is submitted, the user's email is remembered.
  • In the future, this remember me checkmark should utilize the firebase backend. Instead of saving to local, it will use tokens.
  • Created a simple checkmark component...it should be applicable to other use cases.
  • TODO
  • integrate firebase into the component

Testing

  • To locate the login page, go to dashboard, click the 'go to login' link.
  • I tried submitting the form with no text and different combinations of valid and invalid text.
  • I refreshed after checking remember me and submitting...the email was remembered
  • I refreshed after unchecking remember me and submitting...the email was not remembered.
  • I checked remember me and submitted, unchecked remember me, refreshed...vice versa
  • TODO
  • Check basic responsivity
  • Make sure local storage names aren't too generic

Confirmation of Change

Screenshot 2025-02-19 142819
Screenshot 2025-02-19 142811
Screenshot 2025-02-19 142802
Screenshot 2025-02-19 142754
Screenshot 2025-02-19 142747
Screenshot 2025-02-19 142738
Screenshot 2025-02-19 142718

@azpi-arte azpi-arte requested a review from Miyuki-L as a code owner February 19, 2025 22:31
@Miyuki-L Miyuki-L requested a review from r800360 February 20, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login Page
1 participant