Bug Fixes (#120)

## Changes  - fix null HL crash bug - fix keys on unit grid
TritonSE · Jun 27, 2024 · 7f4389a · 7f4389a
1 parent 9bf862f
commit 7f4389a
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 6 deletions.
diff --git a/frontend/src/api/referrals.ts b/frontend/src/api/referrals.ts
@@ -8,7 +8,7 @@ export type CreateReferralRequest = {
 
 export type UpdateReferralRequest = {
   id: string;
-  housingLocator: string;
+  housingLocator?: string;
   referringStaff: string;
   status: string;
 };

diff --git a/frontend/src/api/units.ts b/frontend/src/api/units.ts
@@ -234,7 +234,7 @@ export type Referral = {
   status: ReferralStatus;
   renterCandidate: RenterCandidate;
   unit: Unit;
-  assignedHousingLocator: User;
+  assignedHousingLocator?: User;
   assignedReferringStaff: User;
   updatedAt: string;
   createdAt: string;

diff --git a/frontend/src/components/ReferralTable.tsx b/frontend/src/components/ReferralTable.tsx
@@ -161,7 +161,11 @@ export const ReferralTable = (props: ReferralTableProps) => {
     }
     return (
       <>
-        {referral.assignedHousingLocator.firstName + " " + referral.assignedHousingLocator.lastName}
+        {referral.assignedHousingLocator
+          ? referral.assignedHousingLocator.firstName +
+            " " +
+            referral.assignedHousingLocator.lastName
+          : "N/A"}
       </>
     );
   };

diff --git a/frontend/src/components/UnitCardGrid.tsx b/frontend/src/components/UnitCardGrid.tsx
@@ -36,7 +36,7 @@ export const UnitCardGrid = ({
               refreshUnits={() => {
                 refreshUnits(showPendingUnits ? "pending" : "approved");
               }}
-              key={index}
+              key={`${option.listingAddress}_${index}`}
             />
           ))}
         {units.length === 0 && <HeaderText>No matching units found</HeaderText>}

diff --git a/frontend/src/pages/RenterCandidatePage.tsx b/frontend/src/pages/RenterCandidatePage.tsx
@@ -369,7 +369,11 @@ export function RenterCandidatePage() {
     }
     return (
       <>
-        {referral.assignedHousingLocator.firstName + " " + referral.assignedHousingLocator.lastName}
+        {referral.assignedHousingLocator
+          ? referral.assignedHousingLocator.firstName +
+            " " +
+            referral.assignedHousingLocator.lastName
+          : "N/A"}
       </>
     );
   };
@@ -659,7 +663,11 @@ export function RenterCandidatePage() {
                             {unit.listingAddress}
                           </ListingAddressLink>,
                           assignedReferringStaff.firstName + " " + assignedReferringStaff.lastName,
-                          assignedHousingLocator.firstName + " " + assignedHousingLocator.lastName,
+                          assignedHousingLocator
+                            ? assignedHousingLocator.firstName +
+                              " " +
+                              assignedHousingLocator.lastName
+                            : "N/A",
                           status,
                           formatDate(updatedAt.toString()),
                           <DeleteIcon