Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other methods of payment #39

Open
macjendr opened this issue Oct 21, 2015 · 9 comments
Open

Other methods of payment #39

macjendr opened this issue Oct 21, 2015 · 9 comments
Labels
enhancement question would-like-to-fix A bugfix or enhancement requiring heavy work that the author would like to see fixed.

Comments

@macjendr
Copy link

Hi,

great work, it works very well, but I need to ask - is there an easy method to add new methods, i.e. Sprint Secure Solution or 3XWEB from Franfinance?

Thank you in advance for response :)

@TrogloGeek
Copy link
Owner

Yes, subscribe to SIPS compatible supplementary payment means with your bank and configure accordingly the PAYMENT_MEANS configuration variable from modules back-office

@macjendr
Copy link
Author

Hello again and thank you for your response,

Client claims, that Sprint Secure Solution is activated, I have added SOLUTIONSPRINTSECURE,3 payment mean in tggatos configuration and still receiving error

Transaction invalide

Nous regrettons de ne pouvoir donner suite à votre demande, merci de prendre contact directement avec le commercant en indiquant votre problème

Which is different than incorrect payment mean, so it reads sprint secure but something isn't ok. Did I missed something? Shop is already in PRODUCTION mode by the way.

@TrogloGeek
Copy link
Owner

I'll need the documentation provided with this payment mean to further help.
You should ask bank atos support which can tell you what was wrong in your request (just remember to provide them with at least the hour and transaction_id of the request, you can know your transaction ID by activating debug mode in advanced tab)

@TrogloGeek
Copy link
Owner

oh and do not forget this primary rule of web development : NEVER TRUST A CLIENT ;-)

@macjendr
Copy link
Author

Well, I've received that documentation by email. It's available now here: http://www.pdf-archive.com/2015/10/26/guide-d-implementation-empreinte-cb-uniquement-v0-1/guide-d-implementation-empreinte-cb-uniquement-v0-1.pdf.

I've handled this by adding SOLUTIONSPRINTSECURE_DATA to DATA field in module advanced config with credentials provided by SIPS and it started redirecting correctly, but after that sprintsecure page showing error without any code or clue on google.

Le serveur a détecté une erreur

The server detected an error

Par sécurité, votre demande a été interrompue. Veuillez éventuellement corriger votre requête et la soumettre à nouveau

For safety reason, your request was interrupted. Please correct your request if necessary and submit it again

I've wrote to tech support, but no answer for now. Of course I don't want you to waste time on this, unless my mistake is obvious :) It's good to report every step too I think.

@macjendr
Copy link
Author

oh and do not forget this primary rule of web development : NEVER TRUST A CLIENT ;-)

Ok, client was mistaken and he have 3XWEB service, so everything works flawlessly!

But one last thing - 3XCBFRANFINANCE_DATA field require full name, address, postal code, city and telephone number of customer. How can I achieve that? For test I have provided dummy info but I can't insert customer variables to DATA field in module config, and I want to avoid module modification if possible.

Thank you in advance.

@TrogloGeek
Copy link
Owner

oh and do not forget this primary rule of web development : NEVER TRUST A CLIENT ;-)

Ok, client was mistaken and he have 3XWEB service, so everything works flawlessly!

Experiences gave me mystical supernatural precognition powers ;-)

But one last thing - 3XCBFRANFINANCE_DATA field require full name, address, postal code, city and telephone number of customer. How can I achieve that? For test I have provided dummy info but I can't insert customer variables to DATA field in module config, and I want to avoid module modification if possible.

Yes, had the same thought reading the doc you provided. Never worked with this payment mean before nor had a similar case.
It would require one of these paths:

  • Make the module aware of this payment mean (splitting PAYMENT_MEANS and searching for its value) and when it is active collect and add required data. And of course make a pull request with your new modules version ;-)
  • Order the previous modification from the modules author ;-)
  • Call this module from another and use $mergeParams parameter of TggAtos::getPaymentRedirectionForm($amount, Currency $currency, $mode, $mergeParams = array(), $transaction_id = NULL) to pre-fill the data
  • Implement hooks and have another module using hooks to provide additional data

@macjendr
Copy link
Author

Hello again,

for now I've prepared quick&ugly solution specifically for this case, but I'll be happy to prepare it for pull request and extend this life-saver module with franfinance e-solutions support :)

@TrogloGeek TrogloGeek added the would-like-to-fix A bugfix or enhancement requiring heavy work that the author would like to see fixed. label Jun 2, 2018
@TrogloGeek
Copy link
Owner

I'd like to handle this adding a hook system to allow supplementary PrestaShop modules registering themselves against tggatos as sub-modules, providing new payment means and handling special cases.
This would be a neat way to implement this as tggatos would let the sub-module collect the supplementary data and and them to request payload and could as well override/supplement the response decoding system.

This would require several days work and a lot of testing so probably won't happen soon except if many users needs this feature or if one is keen to help developing or financing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement question would-like-to-fix A bugfix or enhancement requiring heavy work that the author would like to see fixed.
Projects
None yet
Development

No branches or pull requests

2 participants