New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken interface #2

Open

cmocanu opened this issue Jul 12, 2018 · 2 comments

cmocanu commented Jul 12, 2018

The interface should expose set, not put, since put doesn't overwrite the keys, which is the entire point of an LRU cache.

Using put causes duplicate keys.

Member

wizzard0 commented Jul 12, 2018

Um, there's a "set" method exposed, isn't it?

Author

cmocanu commented Jul 12, 2018

Not in ILRUCache

export interface ILRUCache {
    put: (key: string, value: any) => void;
    get: (key: string, Entry: boolean) => any;
}

https://github.com/TrueLink/lru-ts/blob/master/index.ts#L24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment