Skip to content
This repository has been archived by the owner on Mar 1, 2022. It is now read-only.

✨ Added support for filtering by multiple relation columns #15

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Nov 14, 2018

closes #14

  • the code becomes a little hard to read, but i'd not refactor it till we have all cases in place

closes TryGhost#14

- the code becomes a little hard to read, but i'd not refactor it till we have all cases in place
@kirrg001 kirrg001 changed the title [WIP] ✨ Added support for filtering by multiple relation columns ✨ Added support for filtering by multiple relation columns Nov 15, 2018
@kirrg001
Copy link
Contributor Author

@gargol Ready to review

lib/convertor.js Show resolved Hide resolved
lib/convertor.js Show resolved Hide resolved
Copy link
Contributor

@naz naz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's 🚢 this. Will concentrate on TryGhost/Ghost#10159 now

@kirrg001
Copy link
Contributor Author

Will concentrate on TryGhost/Ghost#10159 now

Do you mean TryGhost/Ghost#10160? 🤔

@naz
Copy link
Contributor

naz commented Nov 15, 2018

You are right, we still need TryGhost/Ghost#10160 before TryGhost/Ghost#10159. On it! :)

@kirrg001
Copy link
Contributor Author

👍 and TryGhost/Ghost#10166 🤪

@kirrg001 kirrg001 merged commit 44cd623 into TryGhost:master Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter by multiple relation columns
2 participants